1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-repl-tab-complete

Browse Source 
* Add check for `data` object in tab completion callback
* Replace `.indexOf()` with `.startsWith()` where appropriate

PR-URL: https://github.com/nodejs/node/pull/10879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-01-18 11:00:51 -08:00
parent ba776b3a56
commit b5474c8cee
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-repl-tab-complete.js
View File

@ -231,6 +231,7 @@ putIn.run([
testMe.complete('proxy.', common.mustCall(function(error, data) { testMe.complete('proxy.', common.mustCall(function(error, data) {
assert.strictEqual(error, null); assert.strictEqual(error, null);
assert(Array.isArray(data));
})); }));
// Make sure tab completion does not include integer members of an Array // Make sure tab completion does not include integer members of an Array
@ -307,9 +308,7 @@ const testCustomCompleterSyncMode = repl.start({
input: putIn, input: putIn,
output: putIn, output: putIn,
completer: function completer(line) { completer: function completer(line) {
const hits = customCompletions.filter((c) => { const hits = customCompletions.filter((c) => c.startsWith(line));
return c.indexOf(line) === 0;
});
// Show all completions if none found. // Show all completions if none found.
return [hits.length ? hits : customCompletions, line]; return [hits.length ? hits : customCompletions, line];
} }
@ -339,9 +338,7 @@ const testCustomCompleterAsyncMode = repl.start({
input: putIn, input: putIn,
output: putIn, output: putIn,
completer: function completer(line, callback) { completer: function completer(line, callback) {
const hits = customCompletions.filter((c) => { const hits = customCompletions.filter((c) => c.startsWith(line));
return c.indexOf(line) === 0;
});
// Show all completions if none found. // Show all completions if none found.
callback(null, [hits.length ? hits : customCompletions, line]); callback(null, [hits.length ? hits : customCompletions, line]);
} }