1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: remove unreachable return

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/25883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
ZYSzys 2019-02-02 13:12:06 +08:00 committed by Daniel Bevenius
parent 4e07d210e1
commit b4e670dc26
5 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
benchmark/_cli.js
View File

@ -70,7 +70,6 @@ function CLI(usage, settings) {
} else { } else {
// Bad case, abort // Bad case, abort
this.abort(usage); this.abort(usage);
return;
} }
} }
} }

1
benchmark/common.js
View File

@ -169,7 +169,6 @@ Benchmark.prototype._run = function() {
child.on('close', (code) => { child.on('close', (code) => {
if (code) { if (code) {
process.exit(code); process.exit(code);
return;
} }
if (queueIndex + 1 < self.queue.length) { if (queueIndex + 1 < self.queue.length) {

2
benchmark/compare.js
View File

@ -25,7 +25,6 @@ const cli = CLI(`usage: ./node compare.js [options] [--] <category> ...
if (!cli.optional.new || !cli.optional.old) { if (!cli.optional.new || !cli.optional.old) {
cli.abort(cli.usage); cli.abort(cli.usage);
return;
} }
const binaries = ['old', 'new']; const binaries = ['old', 'new'];
@ -98,7 +97,6 @@ if (showProgress) {
child.once('close', (code) => { child.once('close', (code) => {
if (code) { if (code) {
process.exit(code); process.exit(code);
return;
} }
if (showProgress) { if (showProgress) {
progress.completeRun(job); progress.completeRun(job);

1
benchmark/run.js
View File

@ -67,7 +67,6 @@ if (format === 'csv') {
child.once('close', (code) => { child.once('close', (code) => {
if (code) { if (code) {
process.exit(code); process.exit(code);
return;
} }
// If there are more benchmarks execute the next // If there are more benchmarks execute the next

1
benchmark/scatter.js
View File

@ -17,7 +17,6 @@ const cli = CLI(`usage: ./node scatter.js [options] [--] <filename>
if (cli.items.length !== 1) { if (cli.items.length !== 1) {
cli.abort(cli.usage); cli.abort(cli.usage);
return;
} }
// Create queue from the benchmarks list such both node versions are tested // Create queue from the benchmarks list such both node versions are tested