1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util: Format negative zero as '-0'

Browse Source 
Format negative zero as '-0' instead of as '0', as it does not behave
identically to positive zero. ((-0).toString() still returns '0' as
required by ES5 9.8.1.2).

Fixes joyent/node#6548.
Closes joyent/node#6550.
This commit is contained in:
David Chan 2013-11-20 23:40:41 +05:30 committed by Nathan Rajlich
parent de8c0a51a7
commit b3e4fc6a48
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/util.js
View File

@ -323,8 +323,13 @@ function formatPrimitive(ctx, value) {
.replace(/\\"/g, '"') + '\''; .replace(/\\"/g, '"') + '\'';
return ctx.stylize(simple, 'string'); return ctx.stylize(simple, 'string');
} }
if (isNumber(value)) if (isNumber(value)) {
// Format -0 as '-0'. Strict equality won't distinguish 0 from -0,
// so instead we use the fact that 1 / -0 < 0 whereas 1 / 0 > 0 .
if (value === 0 && 1 / value < 0)
return ctx.stylize('-0', 'number');
return ctx.stylize('' + value, 'number'); return ctx.stylize('' + value, 'number');
}
if (isBoolean(value)) if (isBoolean(value))
return ctx.stylize('' + value, 'boolean'); return ctx.stylize('' + value, 'boolean');
// For some reason typeof null is "object", so special case here. // For some reason typeof null is "object", so special case here.

4
test/simple/test-util-inspect.js
View File

@ -34,6 +34,10 @@ Date2.prototype.foo = 'bar';
var after = util.inspect(d); var after = util.inspect(d);
assert.equal(orig, after); assert.equal(orig, after);
// test positive/negative zero
assert.equal(util.inspect(0), '0');
assert.equal(util.inspect(-0), '-0');
// test for sparse array // test for sparse array
var a = ['foo', 'bar', 'baz']; var a = ['foo', 'bar', 'baz'];
assert.equal(util.inspect(a), '[ \'foo\', \'bar\', \'baz\' ]'); assert.equal(util.inspect(a), '[ \'foo\', \'bar\', \'baz\' ]');