1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: update Collaborator Guide reference

Browse Source 
In pull-requests.md:

* Refer to the Collaborator Guide as Collaborator Guide and not
  Collaborator's Guide. That is how the doc describes itself and we
  should be consistent.

PR-URL: https://github.com/nodejs/node/pull/20473
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rich Trott 2018-05-02 09:03:47 -07:00
parent a59826403a
commit b3c757e07a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/guides/contributing/pull-requests.md
View File

@ -35,7 +35,7 @@ so that you can make the actual changes. This is where we will start.
* [Getting Approvals for your Pull Request](#getting-approvals-for-your-pull-request) * [Getting Approvals for your Pull Request](#getting-approvals-for-your-pull-request)
* [CI Testing](#ci-testing) * [CI Testing](#ci-testing)
* [Waiting Until the Pull Request Gets Landed](#waiting-until-the-pull-request-gets-landed) * [Waiting Until the Pull Request Gets Landed](#waiting-until-the-pull-request-gets-landed)
* [Check Out the Collaborator's Guide](#check-out-the-collaborators-guide) * [Check Out the Collaborator Guide](#check-out-the-collaborator-guide)
## Dependencies ## Dependencies
@ -645,17 +645,17 @@ doesn't need to wait. A Pull Request may well take longer to be
merged in. All these precautions are important because Node.js is merged in. All these precautions are important because Node.js is
widely used, so don't be discouraged! widely used, so don't be discouraged!
### Check Out the Collaborator's Guide ### Check Out the Collaborator Guide
If you want to know more about the code review and the landing process, If you want to know more about the code review and the landing process, see the
you can take a look at the [Collaborator Guide][].
[collaborator's guide](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md).
[approved]: #getting-approvals-for-your-pull-request [approved]: #getting-approvals-for-your-pull-request
[benchmark results]: ../writing-and-running-benchmarks.md [benchmark results]: ../writing-and-running-benchmarks.md
[Building guide]: ../../../BUILDING.md [Building guide]: ../../../BUILDING.md
[CI (Continuous Integration) test run]: #ci-testing [CI (Continuous Integration) test run]: #ci-testing
[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
[Collaborator Guide]: ../../../COLLABORATOR_GUIDE.md
[guide for writing tests in Node.js]: ../writing-tests.md [guide for writing tests in Node.js]: ../writing-tests.md
[https://ci.nodejs.org/]: https://ci.nodejs.org/ [https://ci.nodejs.org/]: https://ci.nodejs.org/
[IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4 [IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4