1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: make sure vtable is generated in addon test with LTO

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/28057
Fixes: https://github.com/nodejs/node/issues/28026
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Anna Henningsen 2019-06-04 17:26:26 +02:00 committed by Daniel Bevenius
parent 65a5f7b65f
commit b31bfaddeb
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/addons/uv-handle-leak/binding.cc
View File

@ -15,9 +15,16 @@ void CloseCallback(uv_handle_t* handle) {}
class ExampleOwnerClass { class ExampleOwnerClass {
public: public:
virtual ~ExampleOwnerClass() {} virtual ~ExampleOwnerClass();
}; };
// Do not inline this into the class, because that may remove the virtual
// table when LTO is used, and with it the symbol for which we grep the process
// output in test/abort/test-addon-uv-handle-leak.
// When the destructor is not inlined, the compiler will have to assume that it,
// and the vtable, is part of what this compilation unit exports, and keep them.
ExampleOwnerClass::~ExampleOwnerClass() {}
ExampleOwnerClass example_instance; ExampleOwnerClass example_instance;
void LeakHandle(const FunctionCallbackInfo<Value>& args) { void LeakHandle(const FunctionCallbackInfo<Value>& args) {