1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add information to assertion

Browse Source 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: https://github.com/nodejs/node/pull/24566
Refs: https://github.com/nodejs/node/issues/24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit is contained in:
Rich Trott 2018-11-22 03:33:05 -08:00 committed by Daniel Bevenius
parent 80671dc1f9
commit b303d8bb21
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/parallel/test-fs-stat-bigint.js
View File

@ -7,6 +7,7 @@ const promiseFs = require('fs').promises;
const path = require('path'); const path = require('path');
const tmpdir = require('../common/tmpdir'); const tmpdir = require('../common/tmpdir');
const { isDate } = require('util').types; const { isDate } = require('util').types;
const { inspect } = require('util');
tmpdir.refresh(); tmpdir.refresh();
@ -62,7 +63,11 @@ function verifyStats(bigintStats, numStats) {
assert.strictEqual(bigintStats[key], undefined); assert.strictEqual(bigintStats[key], undefined);
assert.strictEqual(numStats[key], undefined); assert.strictEqual(numStats[key], undefined);
} else if (Number.isSafeInteger(val)) { } else if (Number.isSafeInteger(val)) {
assert.strictEqual(bigintStats[key], BigInt(val)); assert.strictEqual(
bigintStats[key], BigInt(val),
`${inspect(bigintStats[key])} !== ${inspect(BigInt(val))}\n` +
`key=${key}, val=${val}`
);
} else { } else {
assert( assert(
Math.abs(Number(bigintStats[key]) - val) < 1, Math.abs(Number(bigintStats[key]) - val) < 1,