1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util: ensure that the .inspect function isn't the one being executed

Browse Source 
Fixes #2225.
This commit is contained in:
Nathan Rajlich 2011-11-29 18:21:10 -08:00 committed by Ben Noordhuis
parent 754e23db27
commit b204006105
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/util.js
View File

@ -155,7 +155,7 @@ function formatValue(ctx, value, recurseTimes) {
// Check that value is an object with an inspect function on it // Check that value is an object with an inspect function on it
if (value && typeof value.inspect === 'function' && if (value && typeof value.inspect === 'function' &&
// Filter out the util module, it's inspect function is special // Filter out the util module, it's inspect function is special
value !== exports && value.inspect !== exports.inspect &&
// Also filter out any prototype objects using the circular check. // Also filter out any prototype objects using the circular check.
!(value.constructor && value.constructor.prototype === value)) { !(value.constructor && value.constructor.prototype === value)) {
return value.inspect(recurseTimes); return value.inspect(recurseTimes);

4
test/simple/test-util-inspect.js
View File

@ -75,3 +75,7 @@ assert.doesNotThrow(function () {
r.toString = null; r.toString = null;
util.inspect(r); util.inspect(r);
}); });
// GH-2225
var x = { inspect: util.inspect };
assert.ok(util.inspect(x).indexOf('inspect') != -1);