1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: only emit download ICU warnings once

Browse Source 
The check that the user specified `icu` in `--download` only needs to be
done once and not for each entry in `tools/icu/current_ver.dep`.

Fixes: https://github.com/nodejs/node/issues/26860

PR-URL: https://github.com/nodejs/node/pull/27031
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Richard Lau 2019-03-31 14:22:58 -04:00
parent 15c0947fee
commit b180a15727
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
configure.py
View File

@ -1253,13 +1253,14 @@ def configure_intl(o):
if not os.access(options.download_path, os.W_OK): if not os.access(options.download_path, os.W_OK):
error('''Cannot write to desired download path. error('''Cannot write to desired download path.
Either create it or verify permissions.''') Either create it or verify permissions.''')
attemptdownload = nodedownload.candownload(auto_downloads, "icu")
for icu in icus: for icu in icus:
url = icu['url'] url = icu['url']
md5 = icu['md5'] md5 = icu['md5']
local = url.split('/')[-1] local = url.split('/')[-1]
targetfile = os.path.join(options.download_path, local) targetfile = os.path.join(options.download_path, local)
if not os.path.isfile(targetfile): if not os.path.isfile(targetfile):
if nodedownload.candownload(auto_downloads, "icu"): if attemptdownload:
nodedownload.retrievefile(url, targetfile) nodedownload.retrievefile(url, targetfile)
else: else:
print('Re-using existing %s' % targetfile) print('Re-using existing %s' % targetfile)