1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: remove 72-hour mentions in pull-requests.md

Browse Source 
vsemozhetbyt noted that there were two mentions of the now-defunct
72-hour-rule in pull-requests.md. This change updates the text to
reflect current wait-time rules.

PR-URL: https://github.com/nodejs/node/pull/23309
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rich Trott 2018-10-06 21:35:01 -07:00
parent a9bb653ecc
commit b155358235
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
doc/guides/contributing/pull-requests.md
View File

@ -496,12 +496,11 @@ There is a minimum waiting time which we try to respect for non-trivial
changes, so that people who may have important input in such a distributed changes, so that people who may have important input in such a distributed
project are able to respond. project are able to respond.
For non-trivial changes, Pull Requests must be left open for *at least* 48 For non-trivial changes, Pull Requests must be left open for at least 48 hours.
hours during the week, and 72 hours on a weekend. In most cases, when the In most cases, when the PR is relatively small and focused on a narrow set of
PR is relatively small and focused on a narrow set of changes, these periods changes, that will provide more than enough time to adequately review. Sometimes
provide more than enough time to adequately review. Sometimes changes take far changes take far longer to review, or need more specialized review from subject
longer to review, or need more specialized review from subject matter experts. matter experts. When in doubt, do not rush.
When in doubt, do not rush.
Trivial changes, typically limited to small formatting changes or fixes to Trivial changes, typically limited to small formatting changes or fixes to
documentation, may be landed within the minimum 48 hour window. documentation, may be landed within the minimum 48 hour window.
@ -643,12 +642,11 @@ If not, you can ask a Collaborator to start a CI run.
### Waiting Until the Pull Request Gets Landed ### Waiting Until the Pull Request Gets Landed
A Pull Request needs to stay open for at least 48 hours (72 hours on a A Pull Request needs to stay open for at least 48 hours from when it is
weekend) from when it is submitted, even after it gets approved and submitted, even after it gets approved and passes the CI. This is to make sure
passes the CI. This is to make sure that everyone has a chance to that everyone has a chance to weigh in. If the changes are trivial,
weigh in. If the changes are trivial, collaborators may decide it collaborators may decide it doesn't need to wait. A Pull Request may well take
doesn't need to wait. A Pull Request may well take longer to be longer to be merged in. All these precautions are important because Node.js is
merged in. All these precautions are important because Node.js is
widely used, so don't be discouraged! widely used, so don't be discouraged!
### Check Out the Collaborator Guide ### Check Out the Collaborator Guide