1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-domain-from-timer

Browse Source 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: https://github.com/nodejs/node/pull/9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Daniel Sims 2016-12-01 10:02:15 -06:00 committed by Rich Trott
parent ac78812f7f
commit b0c10a24a6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-domain-from-timer.js
View File

@ -2,17 +2,17 @@
// Simple tests of most basic domain functionality. // Simple tests of most basic domain functionality.
require('../common'); require('../common');
var assert = require('assert'); const assert = require('assert');
// timeouts call the callback directly from cc, so need to make sure the // timeouts call the callback directly from cc, so need to make sure the
// domain will be used regardless // domain will be used regardless
setTimeout(function() { setTimeout(function() {
var domain = require('domain'); const domain = require('domain');
var d = domain.create(); const d = domain.create();
d.run(function() { d.run(function() {
process.nextTick(function() { process.nextTick(function() {
console.trace('in nexttick', process.domain === d); console.trace('in nexttick', process.domain === d);
assert.equal(process.domain, d); assert.strictEqual(process.domain, d);
}); });
}); });
}); }, 1);