1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: remove dead inspector code

Browse Source 
This was overlooked in c58324534c7b1e7868.

Refs: https://github.com/nodejs/node/pull/26137

PR-URL: https://github.com/nodejs/node/pull/26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Anna Henningsen 2019-02-24 21:29:03 +01:00
parent 0fc40c8049
commit b0b370c9b5
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
2 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/inspector/main_thread_interface.cc
View File

@ -96,13 +96,6 @@ class DispatchMessagesTask : public v8::Task {
MainThreadInterface* thread_; MainThreadInterface* thread_;
}; };
void DisposePairCallback(uv_handle_t* ref) {
using AsyncAndInterface = std::pair<uv_async_t, MainThreadInterface*>;
AsyncAndInterface* pair = node::ContainerOf(
&AsyncAndInterface::first, reinterpret_cast<uv_async_t*>(ref));
delete pair;
}
template <typename T> template <typename T>
class AnotherThreadObjectReference { class AnotherThreadObjectReference {
public: public:
@ -231,18 +224,6 @@ MainThreadInterface::~MainThreadInterface() {
handle_->Reset(); handle_->Reset();
} }
// static
void MainThreadInterface::DispatchMessagesAsyncCallback(uv_async_t* async) {
AsyncAndInterface* asyncAndInterface =
node::ContainerOf(&AsyncAndInterface::first, async);
asyncAndInterface->second->DispatchMessages();
}
// static
void MainThreadInterface::CloseAsync(AsyncAndInterface* pair) {
uv_close(reinterpret_cast<uv_handle_t*>(&pair->first), DisposePairCallback);
}
void MainThreadInterface::Post(std::unique_ptr<Request> request) { void MainThreadInterface::Post(std::unique_ptr<Request> request) {
Mutex::ScopedLock scoped_lock(requests_lock_); Mutex::ScopedLock scoped_lock(requests_lock_);
bool needs_notify = requests_.empty(); bool needs_notify = requests_.empty();

5
src/inspector/main_thread_interface.h
View File

@ -89,11 +89,6 @@ class MainThreadInterface {
void RemoveObject(int handle); void RemoveObject(int handle);
private: private:
using AsyncAndInterface = std::pair<uv_async_t, MainThreadInterface*>;
static void DispatchMessagesAsyncCallback(uv_async_t* async);
static void CloseAsync(AsyncAndInterface*);
MessageQueue requests_; MessageQueue requests_;
Mutex requests_lock_; // requests_ live across threads Mutex requests_lock_; // requests_ live across threads
// This queue is to maintain the order of the messages for the cases // This queue is to maintain the order of the messages for the cases