1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: faster case for create buffer from empty string

Browse Source 
When create Buffer from empty string will touch
C++ binding also.

This patch can improve edge case ~70% faster.

PR-URL: https://github.com/nodejs/node/pull/4414
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Jackson Tian 2015-12-18 10:57:21 +08:00 committed by James M Snell
parent 26a4a4bc93
commit afd821a91d
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
benchmark/buffers/buffer_zero.js
View File

@ -3,16 +3,21 @@
const common = require('../common.js');
const bench = common.createBenchmark(main, {
n: [1024]
n: [1024],
type: ['buffer', 'string']
});
const zero = Buffer.alloc(0);
const zeroBuffer = Buffer.alloc(0);
const zeroString = '';
function main(conf) {
var n = +conf.n;
bench.start();
for (let i = 0; i < n * 1024; i++) {
Buffer.from(zero);
}
if (conf.type === 'buffer')
for (let i = 0; i < n * 1024; i++) Buffer.from(zeroBuffer);
else if (conf.type === 'string')
for (let i = 0; i < n * 1024; i++) Buffer.from(zeroString);
bench.end(n);
}

4
lib/buffer.js
View File

@ -212,6 +212,10 @@ function fromString(string, encoding) {
throw new TypeError('"encoding" must be a valid string encoding');
var length = byteLength(string, encoding);
if (length === 0)
return Buffer.alloc(0);
if (length >= (Buffer.poolSize >>> 1))
return binding.createFromString(string, encoding);