From afad3b443e5aa90a771031ea9045182d1ecbf11a Mon Sep 17 00:00:00 2001 From: cjihrig Date: Thu, 28 Mar 2019 08:47:22 -0400 Subject: [PATCH] test: update postmortem metadata test for V8 7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary of changes: - v8dbg_class_FixedTypedArrayBase__external_pointer__Object - Type changed in https://github.com/v8/v8/commit/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8#diff-f3f182b0510ba2ee39ae87e421ff110b. - Use v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t - v8dbg_class_JSArrayBuffer__backing_store__Object - Type changed in https://github.com/v8/v8/commit/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8#diff-f3f182b0510ba2ee39ae87e421ff110b. - Use v8dbg_class_JSArrayBuffer__backing_store__uintptr_t - v8dbg_class_Map__raw_instance_descriptors__DescriptorArray - Changed in https://github.com/v8/v8/commit/d7b08b6da2fd963ab7f74319617050329881a8c2#diff-59788e25dc5196c356894d5e1fac6425 - New constant added to V8: v8dbg_class_Map__instance_descriptors_offset - v8dbg_PointerSizeLog2 - Changed in https://github.com/v8/v8/commit/46d1986812097f712aa7c314c8aa49ec49a33b88#diff-f3f182b0510ba2ee39ae87e421ff110b - Refs: https://bugs.chromium.org/p/v8/issues/detail?id=8477 - Use new constants: v8dbg_SystemPointerSize, v8dbg_SystemPointerSizeLog2, v8dbg_TaggedSize, and v8dbg_TaggedSizeLog2 PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso Reviewed-By: Refael Ackermann --- test/v8-updates/test-postmortem-metadata.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index 81fc21aa6a1..cce4a4d2279 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -64,11 +64,11 @@ function getExpectedSymbols() { 'v8dbg_class_FixedArray__data__uintptr_t', 'v8dbg_class_FixedArrayBase__length__SMI', 'v8dbg_class_FixedTypedArrayBase__base_pointer__Object', - 'v8dbg_class_FixedTypedArrayBase__external_pointer__Object', + 'v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t', 'v8dbg_class_HeapNumber__value__double', 'v8dbg_class_HeapObject__map__Map', 'v8dbg_class_JSArray__length__Object', - 'v8dbg_class_JSArrayBuffer__backing_store__Object', + 'v8dbg_class_JSArrayBuffer__backing_store__uintptr_t', 'v8dbg_class_JSArrayBuffer__byte_length__size_t', 'v8dbg_class_JSArrayBufferView__buffer__Object', 'v8dbg_class_JSArrayBufferView__byte_length__size_t', @@ -84,7 +84,7 @@ function getExpectedSymbols() { 'v8dbg_class_Map__constructor_or_backpointer__Object', 'v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char', 'v8dbg_class_Map__instance_type__uint16_t', - 'v8dbg_class_Map__raw_instance_descriptors__DescriptorArray', + 'v8dbg_class_Map__instance_descriptors_offset', 'v8dbg_class_Map__instance_size_in_words__char', 'v8dbg_class_Oddball__kind_offset__int', 'v8dbg_class_Script__line_ends__Object', @@ -179,7 +179,10 @@ function getExpectedSymbols() { 'v8dbg_OddballUndefined', 'v8dbg_OddballUninitialized', 'v8dbg_OneByteStringTag', - 'v8dbg_PointerSizeLog2', + 'v8dbg_SystemPointerSize', + 'v8dbg_SystemPointerSizeLog2', + 'v8dbg_TaggedSize', + 'v8dbg_TaggedSizeLog2', 'v8dbg_SeqStringTag', 'v8dbg_SlicedStringTag', 'v8dbg_SmiShiftSize',