1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: clarify assigning issues to the TSC

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/22759
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Franziska Hinkelmann 2018-09-07 19:46:30 -04:00 committed by Rich Trott
parent 1f780be7d1
commit af522c1440
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
COLLABORATOR_GUIDE.md
View File

@ -486,9 +486,8 @@ level.
### Involving the TSC ### Involving the TSC
Collaborators may opt to elevate pull requests or issues to the [TSC][] for Collaborators may opt to elevate pull requests or issues to the [TSC][].
discussion by assigning the `tsc-review` label or @-mentioning the This should be done where a pull request:
`@nodejs/tsc` GitHub team. This should be done where a pull request:
- is labeled `semver-major`, or - is labeled `semver-major`, or
- has a significant impact on the codebase, or - has a significant impact on the codebase, or
@ -496,6 +495,11 @@ discussion by assigning the `tsc-review` label or @-mentioning the
- has failed to reach consensus amongst the Collaborators who are - has failed to reach consensus amongst the Collaborators who are
actively participating in the discussion. actively participating in the discussion.
Assign the `tsc-review` label or @-mention the
`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].
Do not use the GitHub UI on the right hand side to assign to
`@nodejs/tsc` or request a review from `@nodejs/tsc`.
The TSC should serve as the final arbiter where required. The TSC should serve as the final arbiter where required.
## Landing Pull Requests ## Landing Pull Requests