1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: remove tracking for exception arrow data

Browse Source 
This is unnecessary since we only run `AppendExceptionLine()`
once per exception at this point anyway.

PR-URL: https://github.com/nodejs/node/pull/17394
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anna Henningsen 2017-11-29 23:40:18 +01:00
parent 92011e417c
commit aeddc3676b
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
3 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/env.h
View File

@ -91,7 +91,6 @@ class ModuleWrap;
V(contextify_global_private_symbol, "node:contextify:global") \
V(decorated_private_symbol, "node:decorated") \
V(npn_buffer_private_symbol, "node:npnBuffer") \
V(processed_private_symbol, "node:processed") \
V(selected_npn_buffer_private_symbol, "node:selectedNpnBuffer") \
V(domain_private_symbol, "node:domain") \

10
src/node.cc
View File

@ -1301,16 +1301,6 @@ void AppendExceptionLine(Environment* env,
Local<Object> err_obj;
if (!er.IsEmpty() && er->IsObject()) {
err_obj = er.As<Object>();
auto context = env->context();
auto processed_private_symbol = env->processed_private_symbol();
// Do it only once per message
if (err_obj->HasPrivate(context, processed_private_symbol).FromJust())
return;
err_obj->SetPrivate(
context,
processed_private_symbol,
True(env->isolate()));
}
// Print (filename):(line number): (message).

4
src/node_contextify.cc
View File

@ -668,9 +668,7 @@ class ContextifyScript : public BaseObject {
compile_options);
if (v8_script.IsEmpty()) {
if (display_errors) {
DecorateErrorStack(env, try_catch);
}
DecorateErrorStack(env, try_catch);
try_catch.ReThrow();
return;
}