1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: require CI status indicator in PRs

Browse Source 
Commits are often landed despite failing on one or more CI platforms.
Having a CI status indicator in the PR should make this less likely to
happen.

PR-URL: https://github.com/nodejs/node/pull/17151
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Nikolai Vavilov 2017-11-20 16:56:33 +02:00 committed by Joyee Cheung
parent 79261f3003
commit ae2bed9938
No known key found for this signature in database
GPG Key ID: F586868AAD831D0C
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
COLLABORATOR_GUIDE.md
View File

@ -142,6 +142,7 @@ test should *fail* before the change, and *pass* after the change.
All pull requests that modify executable code should be subjected to All pull requests that modify executable code should be subjected to
continuous integration tests on the continuous integration tests on the
[project CI server](https://ci.nodejs.org/). [project CI server](https://ci.nodejs.org/).
The pull request should have a CI status indicator if possible.
#### Useful CI Jobs #### Useful CI Jobs