benchmark: favor === over ==
Refs: https://github.com/nodejs/node/pull/7961#discussion_r73788501 PR-URL: https://github.com/nodejs/node/pull/8000 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This commit is contained in:
parent
b7a8a691b4
commit
ae25ed3ccd
@ -50,7 +50,7 @@ function main(conf) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function buildString(str, times) {
|
function buildString(str, times) {
|
||||||
if (times == 1) return str;
|
if (times === 1) return str;
|
||||||
|
|
||||||
return str + buildString(str, times - 1);
|
return str + buildString(str, times - 1);
|
||||||
}
|
}
|
||||||
|
@ -31,7 +31,7 @@ function main(conf) {
|
|||||||
var bob_secret = bob.computeSecret(alice.getPublicKey(), pubEnc, 'hex');
|
var bob_secret = bob.computeSecret(alice.getPublicKey(), pubEnc, 'hex');
|
||||||
|
|
||||||
// alice_secret and bob_secret should be the same
|
// alice_secret and bob_secret should be the same
|
||||||
assert(alice_secret == bob_secret);
|
assert(alice_secret === bob_secret);
|
||||||
|
|
||||||
var alice_cipher = crypto.createCipher(conf.cipher, alice_secret);
|
var alice_cipher = crypto.createCipher(conf.cipher, alice_secret);
|
||||||
var bob_cipher = crypto.createDecipher(conf.cipher, bob_secret);
|
var bob_cipher = crypto.createDecipher(conf.cipher, bob_secret);
|
||||||
|
@ -46,14 +46,14 @@ function server() {
|
|||||||
var onsend = type === 'concat' ? onsendConcat : onsendMulti;
|
var onsend = type === 'concat' ? onsendConcat : onsendMulti;
|
||||||
|
|
||||||
function onsendConcat() {
|
function onsendConcat() {
|
||||||
if (sent++ % num == 0)
|
if (sent++ % num === 0)
|
||||||
for (var i = 0; i < num; i++) {
|
for (var i = 0; i < num; i++) {
|
||||||
socket.send(Buffer.concat(chunk), PORT, '127.0.0.1', onsend);
|
socket.send(Buffer.concat(chunk), PORT, '127.0.0.1', onsend);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
function onsendMulti() {
|
function onsendMulti() {
|
||||||
if (sent++ % num == 0)
|
if (sent++ % num === 0)
|
||||||
for (var i = 0; i < num; i++) {
|
for (var i = 0; i < num; i++) {
|
||||||
socket.send(chunk, PORT, '127.0.0.1', onsend);
|
socket.send(chunk, PORT, '127.0.0.1', onsend);
|
||||||
}
|
}
|
||||||
|
@ -45,7 +45,7 @@ function server() {
|
|||||||
var socket = dgram.createSocket('udp4');
|
var socket = dgram.createSocket('udp4');
|
||||||
|
|
||||||
function onsend() {
|
function onsend() {
|
||||||
if (sent++ % num == 0)
|
if (sent++ % num === 0)
|
||||||
for (var i = 0; i < num; i++)
|
for (var i = 0; i < num; i++)
|
||||||
socket.send(chunk, PORT, '127.0.0.1', onsend);
|
socket.send(chunk, PORT, '127.0.0.1', onsend);
|
||||||
}
|
}
|
||||||
|
@ -37,7 +37,7 @@ function server() {
|
|||||||
var socket = dgram.createSocket('udp4');
|
var socket = dgram.createSocket('udp4');
|
||||||
|
|
||||||
function onsend() {
|
function onsend() {
|
||||||
if (sent++ % num == 0)
|
if (sent++ % num === 0)
|
||||||
for (var i = 0; i < num; i++)
|
for (var i = 0; i < num; i++)
|
||||||
socket.send(chunk, 0, chunk.length, PORT, '127.0.0.1', onsend);
|
socket.send(chunk, 0, chunk.length, PORT, '127.0.0.1', onsend);
|
||||||
}
|
}
|
||||||
|
@ -37,7 +37,7 @@ function server() {
|
|||||||
var socket = dgram.createSocket('udp4');
|
var socket = dgram.createSocket('udp4');
|
||||||
|
|
||||||
function onsend() {
|
function onsend() {
|
||||||
if (sent++ % num == 0)
|
if (sent++ % num === 0)
|
||||||
for (var i = 0; i < num; i++)
|
for (var i = 0; i < num; i++)
|
||||||
socket.send(chunk, PORT, '127.0.0.1', onsend);
|
socket.send(chunk, PORT, '127.0.0.1', onsend);
|
||||||
}
|
}
|
||||||
|
@ -37,7 +37,7 @@ var server = module.exports = http.createServer(function(req, res) {
|
|||||||
var status = 200;
|
var status = 200;
|
||||||
|
|
||||||
var n, i;
|
var n, i;
|
||||||
if (command == 'bytes') {
|
if (command === 'bytes') {
|
||||||
n = ~~arg;
|
n = ~~arg;
|
||||||
if (n <= 0)
|
if (n <= 0)
|
||||||
throw new Error('bytes called with n <= 0');
|
throw new Error('bytes called with n <= 0');
|
||||||
@ -46,7 +46,7 @@ var server = module.exports = http.createServer(function(req, res) {
|
|||||||
}
|
}
|
||||||
body = storedBytes[n];
|
body = storedBytes[n];
|
||||||
|
|
||||||
} else if (command == 'buffer') {
|
} else if (command === 'buffer') {
|
||||||
n = ~~arg;
|
n = ~~arg;
|
||||||
if (n <= 0)
|
if (n <= 0)
|
||||||
throw new Error('buffer called with n <= 0');
|
throw new Error('buffer called with n <= 0');
|
||||||
@ -58,7 +58,7 @@ var server = module.exports = http.createServer(function(req, res) {
|
|||||||
}
|
}
|
||||||
body = storedBuffer[n];
|
body = storedBuffer[n];
|
||||||
|
|
||||||
} else if (command == 'unicode') {
|
} else if (command === 'unicode') {
|
||||||
n = ~~arg;
|
n = ~~arg;
|
||||||
if (n <= 0)
|
if (n <= 0)
|
||||||
throw new Error('unicode called with n <= 0');
|
throw new Error('unicode called with n <= 0');
|
||||||
@ -67,14 +67,14 @@ var server = module.exports = http.createServer(function(req, res) {
|
|||||||
}
|
}
|
||||||
body = storedUnicode[n];
|
body = storedUnicode[n];
|
||||||
|
|
||||||
} else if (command == 'quit') {
|
} else if (command === 'quit') {
|
||||||
res.connection.server.close();
|
res.connection.server.close();
|
||||||
body = 'quitting';
|
body = 'quitting';
|
||||||
|
|
||||||
} else if (command == 'fixed') {
|
} else if (command === 'fixed') {
|
||||||
body = fixed;
|
body = fixed;
|
||||||
|
|
||||||
} else if (command == 'echo') {
|
} else if (command === 'echo') {
|
||||||
res.writeHead(200, { 'Content-Type': 'text/plain',
|
res.writeHead(200, { 'Content-Type': 'text/plain',
|
||||||
'Transfer-Encoding': 'chunked' });
|
'Transfer-Encoding': 'chunked' });
|
||||||
req.pipe(res);
|
req.pipe(res);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user