1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dgram: fix possibly deoptimizing use of arguments

Browse Source 
This commit adds a guard against an out of bounds access of
arguments, and replaces another use of arguments with a named
function parameter.

Refs: https://github.com/nodejs/node/issues/10323
PR-URL: https://github.com/nodejs/node/pull/11242
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Vse Mozhet Byt 2017-02-08 16:02:33 +02:00 committed by cjihrig
parent 5ba00af217
commit adf1ed0146
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/dgram.js
View File

@ -131,7 +131,7 @@ function replaceHandle(self, newHandle) {
self._handle = newHandle;
}
Socket.prototype.bind = function(port_ /*, address, callback*/) {
Socket.prototype.bind = function(port_, address_ /*, callback*/) {
let port = port_;
this._healthCheck();
@ -141,7 +141,7 @@ Socket.prototype.bind = function(port_ /*, address, callback*/) {
this._bindState = BIND_STATE_BINDING;
if (typeof arguments[arguments.length - 1] === 'function')
if (arguments.length && typeof arguments[arguments.length - 1] === 'function')
this.once('listening', arguments[arguments.length - 1]);
if (port instanceof UDP) {
@ -158,7 +158,7 @@ Socket.prototype.bind = function(port_ /*, address, callback*/) {
exclusive = !!port.exclusive;
port = port.port;
} else {
address = typeof arguments[1] === 'function' ? '' : arguments[1];
address = typeof address_ === 'function' ? '' : address_;
exclusive = false;
}