errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER from Error to TypeError as a more accurate representation of the error. PR-URL: https://github.com/nodejs/node/pull/19808 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
parent
a7c25b7d42
commit
add1c02bda
@ -733,10 +733,8 @@ E('ERR_HTTP2_INVALID_INFO_STATUS',
|
||||
'Invalid informational status code: %s', RangeError);
|
||||
E('ERR_HTTP2_INVALID_PACKED_SETTINGS_LENGTH',
|
||||
'Packed settings length must be a multiple of six', RangeError);
|
||||
|
||||
// This should probably be a `TypeError`.
|
||||
E('ERR_HTTP2_INVALID_PSEUDOHEADER',
|
||||
'"%s" is an invalid pseudoheader or is used incorrectly', Error);
|
||||
'"%s" is an invalid pseudoheader or is used incorrectly', TypeError);
|
||||
E('ERR_HTTP2_INVALID_SESSION', 'The session has been destroyed', Error);
|
||||
E('ERR_HTTP2_INVALID_SETTING_VALUE',
|
||||
'Invalid value for setting "%s": %s', TypeError, RangeError);
|
||||
|
@ -36,7 +36,7 @@ function onStream(stream, headers, flags) {
|
||||
() => stream.additionalHeaders({ ':method': 'POST' }),
|
||||
{
|
||||
code: 'ERR_HTTP2_INVALID_PSEUDOHEADER',
|
||||
type: Error,
|
||||
type: TypeError,
|
||||
message: '":method" is an invalid pseudoheader or is used incorrectly'
|
||||
}
|
||||
);
|
||||
|
@ -17,7 +17,7 @@ function isNotError(val) {
|
||||
function isError(val) {
|
||||
common.expectsError({
|
||||
code: 'ERR_HTTP2_INVALID_PSEUDOHEADER',
|
||||
type: Error,
|
||||
type: TypeError,
|
||||
message: '":foo" is an invalid pseudoheader or is used incorrectly'
|
||||
})(val);
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user