1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky async-hooks/test-tlswrap

Browse Source 
There is a race condition in async-hooks/test-tlswrap. This addresses it
by waiting 5 more ticks if the client has not been destroyed yet.

PR-URL: https://github.com/nodejs/node/pull/15744
Fixes: https://github.com/nodejs/node/issues/14404
Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
Rich Trott 2017-10-02 15:16:10 -07:00
parent ddbf07ab89
commit ad652afbe3
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/async-hooks/test-tlswrap.js
View File

@ -91,6 +91,10 @@ function onsecureConnect() {
// TODO: why is client not destroyed here even after 5 ticks? // TODO: why is client not destroyed here even after 5 ticks?
// or could it be that it isn't actually destroyed until // or could it be that it isn't actually destroyed until
// the server is closed? // the server is closed?
if (client.before.length < 3) {
tick(5, tick1);
return;
}
checkInvocations(client, { init: 1, before: 3, after: 3 }, checkInvocations(client, { init: 1, before: 3, after: 3 },
'client: when client destroyed'); 'client: when client destroyed');
// //