1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: correct crypto.randomFill() and randomFillSync()

Browse Source 
Correct return type of `crypto.randomFillSync()` which is of same type as
passed as `buffer` argument.

Correct samples for `randomFill()` and `randomFillSync()` using a `TypeArray`
or `DataView` as these types don't support `.toString(encoding)`.

PR-URL: https://github.com/nodejs/node/pull/21550
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Gerhard Stoebich 2018-06-26 23:49:47 +02:00 committed by Trivikram Kamat
parent b07852d1f7
commit acc633c76e
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
doc/api/crypto.md
View File

@ -2035,7 +2035,7 @@ changes:
* `buffer` {Buffer|TypedArray|DataView} Must be supplied. * `buffer` {Buffer|TypedArray|DataView} Must be supplied.
* `offset` {number} **Default:** `0` * `offset` {number} **Default:** `0`
* `size` {number} **Default:** `buffer.length - offset` * `size` {number} **Default:** `buffer.length - offset`
* Returns: {Buffer} * Returns: {Buffer|TypedArray|DataView} The object passed as `buffer` argument.
Synchronous version of [`crypto.randomFill()`][]. Synchronous version of [`crypto.randomFill()`][].
@ -2055,13 +2055,16 @@ Any `TypedArray` or `DataView` instance may be passed as `buffer`.
```js ```js
const a = new Uint32Array(10); const a = new Uint32Array(10);
console.log(crypto.randomFillSync(a).toString('hex')); console.log(Buffer.from(crypto.randomFillSync(a).buffer,
a.byteOffset, a.byteLength).toString('hex'));
const b = new Float64Array(10); const b = new Float64Array(10);
console.log(crypto.randomFillSync(b).toString('hex')); console.log(Buffer.from(crypto.randomFillSync(b).buffer,
b.byteOffset, b.byteLength).toString('hex'));
const c = new DataView(new ArrayBuffer(10)); const c = new DataView(new ArrayBuffer(10));
console.log(crypto.randomFillSync(c).toString('hex')); console.log(Buffer.from(crypto.randomFillSync(c).buffer,
c.byteOffset, c.byteLength).toString('hex'));
``` ```
### crypto.randomFill(buffer[, offset][, size], callback) ### crypto.randomFill(buffer[, offset][, size], callback)
@ -2109,19 +2112,22 @@ Any `TypedArray` or `DataView` instance may be passed as `buffer`.
const a = new Uint32Array(10); const a = new Uint32Array(10);
crypto.randomFill(a, (err, buf) => { crypto.randomFill(a, (err, buf) => {
if (err) throw err; if (err) throw err;
console.log(buf.toString('hex')); console.log(Buffer.from(buf.buffer, buf.byteOffset, buf.byteLength)
.toString('hex'));
}); });
const b = new Float64Array(10); const b = new Float64Array(10);
crypto.randomFill(b, (err, buf) => { crypto.randomFill(b, (err, buf) => {
if (err) throw err; if (err) throw err;
console.log(buf.toString('hex')); console.log(Buffer.from(buf.buffer, buf.byteOffset, buf.byteLength)
.toString('hex'));
}); });
const c = new DataView(new ArrayBuffer(10)); const c = new DataView(new ArrayBuffer(10));
crypto.randomFill(c, (err, buf) => { crypto.randomFill(c, (err, buf) => {
if (err) throw err; if (err) throw err;
console.log(buf.toString('hex')); console.log(Buffer.from(buf.buffer, buf.byteOffset, buf.byteLength)
.toString('hex'));
}); });
``` ```