1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-domain-exit-dispose-again

Browse Source 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: https://github.com/nodejs/node/pull/10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Ethan Arrowood 2016-12-01 11:22:14 -06:00 committed by Rich Trott
parent 61d6293033
commit ac78812f7f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-domain-exit-dispose-again.js
View File

@ -51,7 +51,7 @@ setTimeout(function firstTimer() {
'a domain that should be disposed.'); 'a domain that should be disposed.');
disposalFailed = true; disposalFailed = true;
process.exit(1); process.exit(1);
}); }, 1);
// Make V8 throw an unreferenced error. As a result, the domain's error // Make V8 throw an unreferenced error. As a result, the domain's error
// handler is called, which disposes the domain "d" and should prevent the // handler is called, which disposes the domain "d" and should prevent the
@ -69,8 +69,8 @@ setTimeout(function secondTimer() {
}, TIMEOUT_DURATION); }, TIMEOUT_DURATION);
process.on('exit', function() { process.on('exit', function() {
assert.equal(a, 10); assert.strictEqual(a, 10);
assert.equal(disposalFailed, false); assert.strictEqual(disposalFailed, false);
assert(secondTimerRan); assert(secondTimerRan);
console.log('ok'); console.log('ok');
}); });