1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: http2 session operations after destroy

Browse Source 
Refs #14985

PR-URL: https://github.com/nodejs/node/pull/15758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
This commit is contained in:
Trivikram Kamat 2017-10-03 00:44:09 -07:00 committed by James M Snell
parent 68df587b1e
commit abbdcaa6e8
2 changed files with 31 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/parallel/test-http2-server-destroy-before-shutdown.js
View File

@ -1,30 +0,0 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const server = http2.createServer();
// Test that ERR_HTTP2_INVALID_SESSION is thrown when a stream is destroyed
// before calling stream.session.shutdown
server.on('stream', common.mustCall((stream) => {
stream.session.destroy();
common.expectsError(
() => stream.session.shutdown(),
{
type: Error,
code: 'ERR_HTTP2_INVALID_SESSION',
message: 'The session has been destroyed'
}
);
}));
server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
const req = client.request();
req.resume();
req.on('end', common.mustCall(() => server.close()));
}));

42
test/parallel/test-http2-server-stream-session-destroy.js
View File

@ -11,11 +11,6 @@ const server = h2.createServer();
server.on( server.on(
'stream', 'stream',
common.mustCall((stream) => { common.mustCall((stream) => {
const errorObj = {
type: Error,
code: 'ERR_HTTP2_INVALID_STREAM',
message: 'The stream has been destroyed'
};
stream.session.destroy(); stream.session.destroy();
// Test that stream.state getter returns an empty object // Test that stream.state getter returns an empty object
@ -24,15 +19,40 @@ server.on(
// Test that ERR_HTTP2_INVALID_STREAM is thrown while calling // Test that ERR_HTTP2_INVALID_STREAM is thrown while calling
// stream operations after the stream session has been destroyed // stream operations after the stream session has been destroyed
common.expectsError(() => stream.additionalHeaders(), errorObj); const invalidStreamError = {
common.expectsError(() => stream.priority(), errorObj); type: Error,
code: 'ERR_HTTP2_INVALID_STREAM',
message: 'The stream has been destroyed'
};
common.expectsError(() => stream.additionalHeaders(), invalidStreamError);
common.expectsError(() => stream.priority(), invalidStreamError);
common.expectsError( common.expectsError(
() => stream.pushStream({}, common.mustNotCall()), () => stream.pushStream({}, common.mustNotCall()),
errorObj invalidStreamError
); );
common.expectsError(() => stream.respond(), errorObj); common.expectsError(() => stream.respond(), invalidStreamError);
common.expectsError(() => stream.rstStream(), errorObj); common.expectsError(() => stream.rstStream(), invalidStreamError);
common.expectsError(() => stream.write('data'), errorObj); common.expectsError(() => stream.write('data'), invalidStreamError);
// Test that ERR_HTTP2_INVALID_SESSION is thrown while calling
// session operations after the stream session has been destroyed
const invalidSessionError = {
type: Error,
code: 'ERR_HTTP2_INVALID_SESSION',
message: 'The session has been destroyed'
};
common.expectsError(() => stream.session.priority(), invalidSessionError);
common.expectsError(() => stream.session.settings(), invalidSessionError);
common.expectsError(() => stream.session.shutdown(), invalidSessionError);
// Wait for setImmediate call from destroy() to complete
// so that state.destroyed is set to true
setImmediate((session) => {
common.expectsError(() => session.priority(), invalidSessionError);
common.expectsError(() => session.settings(), invalidSessionError);
common.expectsError(() => session.shutdown(), invalidSessionError);
common.expectsError(() => session.rstStream(), invalidSessionError);
}, stream.session);
}) })
); );