1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: remove some unnecessary next ticks

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/19451
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
James M Snell 2018-03-19 08:17:26 -07:00
parent e714da6f0a
commit ab755484a8
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/internal/http2/core.js
View File

@ -409,7 +409,7 @@ function onSettings() {
session[kUpdateTimer](); session[kUpdateTimer]();
debug(`Http2Session ${sessionName(session[kType])}: new settings received`); debug(`Http2Session ${sessionName(session[kType])}: new settings received`);
session[kRemoteSettings] = undefined; session[kRemoteSettings] = undefined;
process.nextTick(emit, session, 'remoteSettings', session.remoteSettings); session.emit('remoteSettings', session.remoteSettings);
} }
// If the stream exists, an attempt will be made to emit an event // If the stream exists, an attempt will be made to emit an event
@ -425,7 +425,7 @@ function onPriority(id, parent, weight, exclusive) {
const emitter = session[kState].streams.get(id) || session; const emitter = session[kState].streams.get(id) || session;
if (!emitter.destroyed) { if (!emitter.destroyed) {
emitter[kUpdateTimer](); emitter[kUpdateTimer]();
process.nextTick(emit, emitter, 'priority', id, parent, weight, exclusive); emitter.emit('priority', id, parent, weight, exclusive);
} }
} }
@ -439,7 +439,7 @@ function onFrameError(id, type, code) {
`type ${type} on stream ${id}, code: ${code}`); `type ${type} on stream ${id}, code: ${code}`);
const emitter = session[kState].streams.get(id) || session; const emitter = session[kState].streams.get(id) || session;
emitter[kUpdateTimer](); emitter[kUpdateTimer]();
process.nextTick(emit, emitter, 'frameError', type, code, id); emitter.emit('frameError', type, code, id);
} }
function onAltSvc(stream, origin, alt) { function onAltSvc(stream, origin, alt) {
@ -449,7 +449,7 @@ function onAltSvc(stream, origin, alt) {
debug(`Http2Session ${sessionName(session[kType])}: altsvc received: ` + debug(`Http2Session ${sessionName(session[kType])}: altsvc received: ` +
`stream: ${stream}, origin: ${origin}, alt: ${alt}`); `stream: ${stream}, origin: ${origin}, alt: ${alt}`);
session[kUpdateTimer](); session[kUpdateTimer]();
process.nextTick(emit, session, 'altsvc', alt, origin, stream); session.emit('altsvc', alt, origin, stream);
} }
// Receiving a GOAWAY frame from the connected peer is a signal that no // Receiving a GOAWAY frame from the connected peer is a signal that no
@ -771,7 +771,7 @@ function setupHandle(socket, type, options) {
// core will check for session.destroyed before progressing, this // core will check for session.destroyed before progressing, this
// ensures that those at l`east get cleared out. // ensures that those at l`east get cleared out.
if (this.destroyed) { if (this.destroyed) {
process.nextTick(emit, this, 'connect', this, socket); this.emit('connect', this, socket);
return; return;
} }
debug(`Http2Session ${sessionName(type)}: setting up session handle`); debug(`Http2Session ${sessionName(type)}: setting up session handle`);
@ -813,7 +813,7 @@ function setupHandle(socket, type, options) {
options.settings : {}; options.settings : {};
this.settings(settings); this.settings(settings);
process.nextTick(emit, this, 'connect', this, socket); this.emit('connect', this, socket);
} }
// Emits a close event followed by an error event if err is truthy. Used // Emits a close event followed by an error event if err is truthy. Used
@ -1262,7 +1262,7 @@ class Http2Session extends EventEmitter {
} }
} }
process.nextTick(emit, this, 'timeout'); this.emit('timeout');
} }
ref() { ref() {
@ -1485,8 +1485,8 @@ function streamOnPause() {
function abort(stream) { function abort(stream) {
if (!stream.aborted && if (!stream.aborted &&
!(stream._writableState.ended || stream._writableState.ending)) { !(stream._writableState.ended || stream._writableState.ending)) {
process.nextTick(emit, stream, 'aborted');
stream[kState].flags |= STREAM_FLAGS_ABORTED; stream[kState].flags |= STREAM_FLAGS_ABORTED;
stream.emit('aborted');
} }
} }
@ -1612,7 +1612,7 @@ class Http2Stream extends Duplex {
} }
} }
process.nextTick(emit, this, 'timeout'); this.emit('timeout');
} }
// true if the HEADERS frame has been sent // true if the HEADERS frame has been sent