From ab3f7afacc0b8d76737935649e23c72ef61502c8 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Tue, 19 Mar 2019 01:56:32 +0100 Subject: [PATCH] console: fix trace function A recent refactoring made the slight mistake of calling `trace()` instead of `this.trace()`. PR-URL: https://github.com/nodejs/node/pull/26764 Fixes: https://github.com/nodejs/node/issues/26763 Reviewed-By: Richard Lau Reviewed-By: Gus Caplan Reviewed-By: Yongsheng Zhang Reviewed-By: Weijia Wang Reviewed-By: Luigi Pinca Reviewed-By: Anto Aravinth --- lib/internal/console/constructor.js | 2 +- test/message/console.js | 5 +++++ test/message/console.out | 10 ++++++++++ 3 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 test/message/console.js create mode 100644 test/message/console.out diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js index b9af931d385..1b9c4e7ba03 100644 --- a/lib/internal/console/constructor.js +++ b/lib/internal/console/constructor.js @@ -331,7 +331,7 @@ const consoleMethods = { name: 'Trace', message: this[kFormatForStderr](args) }; - Error.captureStackTrace(err, trace); + Error.captureStackTrace(err, this.trace); this.error(err.stack); }, diff --git a/test/message/console.js b/test/message/console.js new file mode 100644 index 00000000000..e93e27b3d4f --- /dev/null +++ b/test/message/console.js @@ -0,0 +1,5 @@ +'use strict'; + +require('../common'); + +console.trace('foo'); diff --git a/test/message/console.out b/test/message/console.out new file mode 100644 index 00000000000..0a19ff8be32 --- /dev/null +++ b/test/message/console.out @@ -0,0 +1,10 @@ +Trace: foo + at Object.trace (*) + at Object. (*console.js:*:*) + at * + at * + at * + at * + at * + at * + at *