1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cluster: close ownerless handles on disconnect()

Browse Source 
When a worker is disconnecting, it shuts down all of the handles
it is waiting on. It is possible that a handle does not have an
owner, which causes a crash. This commit closes such handles
without accessing the missing owner.

Fixes: https://github.com/nodejs/node/issues/6561
PR-URL: https://github.com/nodejs/node/pull/6909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit is contained in:
cjihrig 2016-05-23 10:55:48 -04:00
parent dd21bd9f01
commit aadfe6c249
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/cluster.js
View File

@ -719,7 +719,11 @@ function workerInit() {
const handle = handles[key]; const handle = handles[key];
delete handles[key]; delete handles[key];
waitingCount++; waitingCount++;
if (handle.owner)
handle.owner.close(checkWaitingCount); handle.owner.close(checkWaitingCount);
else
handle.close(checkWaitingCount);
} }
checkWaitingCount(); checkWaitingCount();