1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: use direct parameters instead

Browse Source 
When parameter count is fixed, use literal Array instance is more
simply and avoid arguments leak also.

PR-URL: https://github.com/nodejs/node/pull/10833
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This commit is contained in:
Jackson Tian 2017-01-16 16:56:48 +08:00 committed by Italo A. Casas
parent 90c2ac7be3
commit aa8eb8747c
No known key found for this signature in database
GPG Key ID: 23EFEFE93C4CFFFE
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/_http_client.js
View File

@ -718,21 +718,15 @@ ClientRequest.prototype.setTimeout = function setTimeout(msecs, callback) {
return this; return this;
}; };
ClientRequest.prototype.setNoDelay = function setNoDelay() { ClientRequest.prototype.setNoDelay = function setNoDelay(noDelay) {
const argsLen = arguments.length; this._deferToConnect('setNoDelay', [noDelay]);
const args = new Array(argsLen);
for (var i = 0; i < argsLen; i++)
args[i] = arguments[i];
this._deferToConnect('setNoDelay', args);
};
ClientRequest.prototype.setSocketKeepAlive = function setSocketKeepAlive() {
const argsLen = arguments.length;
const args = new Array(argsLen);
for (var i = 0; i < argsLen; i++)
args[i] = arguments[i];
this._deferToConnect('setKeepAlive', args);
}; };
ClientRequest.prototype.setSocketKeepAlive =
function setSocketKeepAlive(enable, initialDelay) {
this._deferToConnect('setKeepAlive', [enable, initialDelay]);
};
ClientRequest.prototype.clearTimeout = function clearTimeout(cb) { ClientRequest.prototype.clearTimeout = function clearTimeout(cb) {
this.setTimeout(0, cb); this.setTimeout(0, cb);
}; };