1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: add constant kMaxCallbacksUntilQueueIsShortened

Browse Source 
Currently the maximum number of tick is duplicated in two places. This
commit introduces a constant that both can use.

PR-URL: https://github.com/nodejs/node/pull/11199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
Daniel Bevenius 2017-02-03 12:46:23 +01:00 committed by James M Snell
parent a08fcc02f8
commit aa05209d6d
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/internal/process/next_tick.js
View File

@ -1,5 +1,11 @@
'use strict'; 'use strict';
// This value is used to prevent the nextTickQueue from becoming too
// large and cause the process to run out of memory. When this value
// is reached the nextTimeQueue array will be shortend (see tickDone
// for details).
const kMaxCallbacksUntilQueueIsShortened = 1e4;
exports.setup = setupNextTick; exports.setup = setupNextTick;
function setupNextTick() { function setupNextTick() {
@ -96,7 +102,7 @@ function setupNextTick() {
// callback invocation with small numbers of arguments to avoid the // callback invocation with small numbers of arguments to avoid the
// performance hit associated with using `fn.apply()` // performance hit associated with using `fn.apply()`
_combinedTickCallback(args, callback); _combinedTickCallback(args, callback);
if (1e4 < tickInfo[kIndex]) if (kMaxCallbacksUntilQueueIsShortened < tickInfo[kIndex])
tickDone(); tickDone();
} }
tickDone(); tickDone();
@ -120,7 +126,7 @@ function setupNextTick() {
// callback invocation with small numbers of arguments to avoid the // callback invocation with small numbers of arguments to avoid the
// performance hit associated with using `fn.apply()` // performance hit associated with using `fn.apply()`
_combinedTickCallback(args, callback); _combinedTickCallback(args, callback);
if (1e4 < tickInfo[kIndex]) if (kMaxCallbacksUntilQueueIsShortened < tickInfo[kIndex])
tickDone(); tickDone();
if (domain) if (domain)
domain.exit(); domain.exit();