1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

deps: backport 23f2736a from v8 upstream

Browse Source 
Original text:

    Fix corner case in x64 compare stubs.

    BUG=v8:2416

    Review URL: https://codereview.chromium.org/11413087

fix #7528
This commit is contained in:
Fedor Indutny 2014-05-02 22:44:45 +04:00
parent bfe1fdb8ab
commit a960d1707a
2 changed files with 76 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
deps/v8/src/x64/code-stubs-x64.cc vendored
View File

@ -5580,7 +5580,7 @@ void ICCompareStub::GenerateSmis(MacroAssembler* masm) {
__ subq(rdx, rax);
__ j(no_overflow, &done, Label::kNear);
// Correct sign of result in case of overflow.
__ SmiNot(rdx, rdx);
__ not_(rdx);
__ bind(&done);
__ movq(rax, rdx);
}

75
deps/v8/test/mjsunit/regress/regress-2416.js vendored Normal file
View File

@ -0,0 +1,75 @@
// Copyright 2012 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
assertFalse(2147483647 < -2147483648)
assertFalse(2147483647 <= -2147483648)
assertFalse(2147483647 == -2147483648)
assertTrue(2147483647 >= -2147483648)
assertTrue(2147483647 > -2147483648)
assertTrue(-2147483648 < 2147483647)
assertTrue(-2147483648 <= 2147483647)
assertFalse(-2147483648 == 2147483647)
assertFalse(-2147483648 >= 2147483647)
assertFalse(-2147483648 > 2147483647)
assertFalse(2147483647 < 2147483647)
assertTrue(2147483647 <= 2147483647)
assertTrue(2147483647 == 2147483647)
assertTrue(2147483647 >= 2147483647)
assertFalse(2147483647 > 2147483647)
assertFalse(-2147483648 < -2147483648)
assertTrue(-2147483648 <= -2147483648)
assertTrue(-2147483648 == -2147483648)
assertTrue(-2147483648 >= -2147483648)
assertFalse(-2147483648 > -2147483648)
assertFalse(1073741823 < -1073741824)
assertFalse(1073741823 <= -1073741824)
assertFalse(1073741823 == -1073741824)
assertTrue(1073741823 >= -1073741824)
assertTrue(1073741823 > -1073741824)
assertTrue(-1073741824 < 1073741823)
assertTrue(-1073741824 <= 1073741823)
assertFalse(-1073741824 == 1073741823)
assertFalse(-1073741824 >= 1073741823)
assertFalse(-1073741824 > 1073741823)
assertFalse(1073741823 < 1073741823)
assertTrue(1073741823 <= 1073741823)
assertTrue(1073741823 == 1073741823)
assertTrue(1073741823 >= 1073741823)
assertFalse(1073741823 > 1073741823)
assertFalse(-1073741824 < -1073741824)
assertTrue(-1073741824 <= -1073741824)
assertTrue(-1073741824 == -1073741824)
assertTrue(-1073741824 >= -1073741824)
assertFalse(-1073741824 > -1073741824)