1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "console: use consolePropAttributes for k-bind properties in constructor"

Browse Source 
This reverts commit ed5e69d7e6eaf5e887ff48aa3fe941d394c44846.

PR-URL: https://github.com/nodejs/node/pull/26943
Refs: https://github.com/nodejs/node/pull/26850#issuecomment-477089697
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
Daniel Bevenius 2019-03-27 12:47:54 +01:00
parent ed5e69d7e6
commit a8eac78f8d
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/internal/console/constructor.js
View File

@ -181,13 +181,15 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) {
...consolePropAttributes, ...consolePropAttributes,
value: Boolean(ignoreErrors) value: Boolean(ignoreErrors)
}, },
'_times': { ...consolePropAttributes, value: new Map() }, '_times': { ...consolePropAttributes, value: new Map() }
// Corresponds to https://console.spec.whatwg.org/#count-map
[kCounts]: { ...consolePropAttributes, value: new Map() },
[kColorMode]: { ...consolePropAttributes, value: colorMode },
[kIsConsole]: { ...consolePropAttributes, value: true },
[kGroupIndent]: { ...consolePropAttributes, value: '' }
}); });
// TODO(joyeecheung): use consolePropAttributes for these
// Corresponds to https://console.spec.whatwg.org/#count-map
this[kCounts] = new Map();
this[kColorMode] = colorMode;
this[kIsConsole] = true;
this[kGroupIndent] = '';
}; };
// Make a function that can serve as the callback passed to `stream.write()`. // Make a function that can serve as the callback passed to `stream.write()`.