1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: use existing handlers instead of duplicated code

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/19267
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Sergey Golovin 2018-03-08 15:30:46 +03:00 committed by Ruben Bridgewater
parent b34a1e1785
commit a892d9a0c1
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/internal/url.js
View File

@ -256,20 +256,6 @@ function onParseProtocolComplete(flags, protocol, username, password,
ctx.port = port; ctx.port = port;
} }
function onParseHostComplete(flags, protocol, username, password,
host, port, path, query, fragment) {
const ctx = this[context];
if ((flags & URL_FLAGS_HAS_HOST) !== 0) {
ctx.host = host;
ctx.flags |= URL_FLAGS_HAS_HOST;
} else {
ctx.host = null;
ctx.flags &= ~URL_FLAGS_HAS_HOST;
}
if (port !== null)
ctx.port = port;
}
function onParseHostnameComplete(flags, protocol, username, password, function onParseHostnameComplete(flags, protocol, username, password,
host, port, path, query, fragment) { host, port, path, query, fragment) {
const ctx = this[context]; const ctx = this[context];
@ -287,6 +273,13 @@ function onParsePortComplete(flags, protocol, username, password,
this[context].port = port; this[context].port = port;
} }
function onParseHostComplete(flags, protocol, username, password,
host, port, path, query, fragment) {
onParseHostnameComplete.apply(this, arguments);
if (port !== null)
onParsePortComplete.apply(this, arguments);
}
function onParsePathComplete(flags, protocol, username, password, function onParsePathComplete(flags, protocol, username, password,
host, port, path, query, fragment) { host, port, path, query, fragment) {
const ctx = this[context]; const ctx = this[context];