1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: remove unnecessary Makefile output

Browse Source 
Remove unnecessary @echo commands from Makefile.

These were originally comments but were changed to @echo in 6bc43aeea79.
They aren't terribly useful so let's remove them.

PR-URL: https://github.com/nodejs/node/pull/23129
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2018-09-27 09:50:11 -07:00
parent d407291dcc
commit a79c88a4ce
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Makefile
View File

@ -279,8 +279,6 @@ jstest: build-addons build-addons-napi ## Runs addon tests and JS tests
# This does not run tests of third-party libraries inside deps. # This does not run tests of third-party libraries inside deps.
test: all ## Runs default tests, linters, and builds docs. test: all ## Runs default tests, linters, and builds docs.
$(MAKE) -s test-doc $(MAKE) -s test-doc
@echo "Build the addons before running the tests so the test results"
@echo "can be displayed together"
$(MAKE) -s build-addons $(MAKE) -s build-addons
$(MAKE) -s build-addons-napi $(MAKE) -s build-addons-napi
$(MAKE) -s cctest $(MAKE) -s cctest
@ -288,8 +286,6 @@ test: all ## Runs default tests, linters, and builds docs.
.PHONY: test-only .PHONY: test-only
test-only: all ## For a quick test, does not run linter or build docs. test-only: all ## For a quick test, does not run linter or build docs.
@echo "Build the addons before running the tests so the test results"
@echo "can be displayed together"
$(MAKE) build-addons $(MAKE) build-addons
$(MAKE) build-addons-napi $(MAKE) build-addons-napi
$(MAKE) cctest $(MAKE) cctest
@ -297,8 +293,6 @@ test-only: all ## For a quick test, does not run linter or build docs.
# Used by `make coverage-test` # Used by `make coverage-test`
test-cov: all test-cov: all
@echo "Build the addons before running the tests so the test results"
@echo "can be displayed together"
$(MAKE) build-addons $(MAKE) build-addons
$(MAKE) build-addons-napi $(MAKE) build-addons-napi
# $(MAKE) cctest # $(MAKE) cctest