1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dns: remove Resolver#cancel() from promises API

Browse Source 
Because reasons.

PR-URL: https://github.com/nodejs/node/pull/21264
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
cjihrig 2018-06-20 09:19:12 -04:00
parent 7486c4d710
commit a77b30ca7f
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/api/dns.md
View File

@ -622,14 +622,6 @@ The following methods from the `dnsPromises` API are available:
* [`resolver.resolveTxt()`][`dnsPromises.resolveTxt()`] * [`resolver.resolveTxt()`][`dnsPromises.resolveTxt()`]
* [`resolver.reverse()`][`dnsPromises.reverse()`] * [`resolver.reverse()`][`dnsPromises.reverse()`]
#### resolver.cancel()
<!-- YAML
added: REPLACEME
-->
Cancel all outstanding DNS queries made by this resolver. The corresponding
`Promise`s will be rejected with an error with code `ECANCELLED`.
### dnsPromises.getServers() ### dnsPromises.getServers()
<!-- YAML <!-- YAML
added: REPLACEME added: REPLACEME

1
lib/internal/dns/promises.js
View File

@ -212,7 +212,6 @@ class Resolver {
} }
} }
Resolver.prototype.cancel = CallbackResolver.prototype.cancel;
Resolver.prototype.getServers = CallbackResolver.prototype.getServers; Resolver.prototype.getServers = CallbackResolver.prototype.getServers;
Resolver.prototype.setServers = CallbackResolver.prototype.setServers; Resolver.prototype.setServers = CallbackResolver.prototype.setServers;
Resolver.prototype.resolveAny = resolveMap.ANY = resolver('queryAny'); Resolver.prototype.resolveAny = resolveMap.ANY = resolver('queryAny');