1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: rename test-regress-GH-784.js

Browse Source 
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
Ujjwal Sharma 2018-03-06 19:39:10 +05:30 committed by Gus Caplan
parent db30142ece
commit a73a071a05
No known key found for this signature in database
GPG Key ID: F00BD11880E82F0E
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/sequential/test-regress-GH-784.js → test/sequential/test-http-econnrefused.js
View File

@ -20,15 +20,15 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
// Regression test for GH-784
// https://github.com/joyent/node/issues/784
//
const common = require('../common');
// The test works by making a total of 8 requests to the server. The first
// two are made with the server off - they should come back as ECONNREFUSED.
// The next two are made with server on - they should come back successful.
// The next two are made with the server off - and so on. Without the fix
// we were experiencing parse errors and instead of ECONNREFUSED.
const common = require('../common');
// we were experiencing parse errors instead of ECONNREFUSED.
// https://github.com/nodejs/node-v0.x-archive/issues/784
const http = require('http');
const assert = require('assert');