1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: update module version mismatch error message

Browse Source 
Fixes: https://github.com/nodejs/node/issues/8379
PR-URL: https://github.com/nodejs/node/pull/8391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
James M Snell 2016-09-02 11:54:51 -07:00
parent 07b54ec4ca
commit a6e1be4a4e
4 changed files with 42 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/node.cc
View File

@ -2406,8 +2406,13 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
char errmsg[1024];
snprintf(errmsg,
sizeof(errmsg),
"Module version mismatch. Expected %d, got %d.",
NODE_MODULE_VERSION, mp->nm_version);
"The module '%s'"
"\nwas compiled against a different Node.js version using"
"\nNODE_MODULE_VERSION %d. This version of Node.js requires"
"\nNODE_MODULE_VERSION %d. Please try re-compiling or "
"re-installing\nthe module (for instance, using `npm rebuild` or"
"`npm install`).",
*filename, mp->nm_version, NODE_MODULE_VERSION);
// NOTE: `mp` is allocated inside of the shared library's memory, calling
// `uv_dlclose` will deallocate it

15
test/addons/node-module-version/binding.cc Normal file
View File

@ -0,0 +1,15 @@
#include <node_version.h>
#undef NODE_MODULE_VERSION
#define NODE_MODULE_VERSION 42
#include <node.h>
namespace {
inline void Initialize(v8::Local<v8::Object> exports,
v8::Local<v8::Value> module,
v8::Local<v8::Context> context) {
}
}
NODE_MODULE_CONTEXT_AWARE(binding, Initialize)

9
test/addons/node-module-version/binding.gyp Normal file
View File

@ -0,0 +1,9 @@
{
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
}
]
}

11
test/addons/node-module-version/test.js Normal file
View File

@ -0,0 +1,11 @@
'use strict';
require('../../common');
const assert = require('assert');
const re = new RegExp(
'was compiled against a different Node.js version using\n' +
'NODE_MODULE_VERSION 42. This version of Node.js requires\n' +
`NODE_MODULE_VERSION ${process.versions.modules}.`);
assert.throws(() => require('./build/Release/binding'), re);