1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-https-truncate

Browse Source 
Changes assert.equal to assert.strictEqual to ensure specificity.

Changes var declarations to const/let where appropriate.

PR-URL: https://github.com/nodejs/node/pull/10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit is contained in:
davidmarkclements 2016-12-01 14:23:55 -06:00 committed by Rich Trott
parent 1259b8834f
commit a6ddd57f29
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/parallel/test-https-truncate.js
View File

@ -1,34 +1,34 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var https = require('https');
const https = require('https');
var fs = require('fs');
const fs = require('fs');
var key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
var cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
const key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
const cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
// number of bytes discovered empirically to trigger the bug
var data = Buffer.allocUnsafe(1024 * 32 + 1);
const data = Buffer.allocUnsafe(1024 * 32 + 1);
httpsTest();
function httpsTest() {
var sopt = { key: key, cert: cert };
const sopt = { key: key, cert: cert };
var server = https.createServer(sopt, function(req, res) {
const server = https.createServer(sopt, function(req, res) {
res.setHeader('content-length', data.length);
res.end(data);
server.close();
});
server.listen(0, function() {
var opts = { port: this.address().port, rejectUnauthorized: false };
const opts = { port: this.address().port, rejectUnauthorized: false };
https.get(opts).on('response', function(res) {
test(res);
});
@ -38,14 +38,14 @@ function httpsTest() {
function test(res) {
res.on('end', function() {
assert.equal(res._readableState.length, 0);
assert.equal(bytes, data.length);
assert.strictEqual(res._readableState.length, 0);
assert.strictEqual(bytes, data.length);
console.log('ok');
});
// Pause and then resume on each chunk, to ensure that there will be
// a lone byte hanging out at the very end.
var bytes = 0;
let bytes = 0;
res.on('data', function(chunk) {
bytes += chunk.length;
this.pause();