1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test to use arrow functions

Browse Source 
In `test/parallel/test-cluster-send-deadlock.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.

PR-URL: https://github.com/nodejs/node/pull/24479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
sagirk 2018-11-19 14:50:15 +05:30 committed by Gireesh Punathil
parent 4d35fa7d07
commit a67b22a218
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-cluster-send-deadlock.js
View File

@ -30,31 +30,31 @@ const net = require('net');
if (cluster.isMaster) { if (cluster.isMaster) {
const worker = cluster.fork(); const worker = cluster.fork();
worker.on('exit', function(code, signal) { worker.on('exit', (code, signal) => {
assert.strictEqual(code, 0, `Worker exited with an error code: ${code}`); assert.strictEqual(code, 0, `Worker exited with an error code: ${code}`);
assert(!signal, `Worker exited by a signal: ${signal}`); assert(!signal, `Worker exited by a signal: ${signal}`);
server.close(); server.close();
}); });
const server = net.createServer(function(socket) { const server = net.createServer((socket) => {
worker.send('handle', socket); worker.send('handle', socket);
}); });
server.listen(0, function() { server.listen(0, () => {
worker.send({ message: 'listen', port: server.address().port }); worker.send({ message: 'listen', port: server.address().port });
}); });
} else { } else {
process.on('message', function(msg, handle) { process.on('message', (msg, handle) => {
if (msg.message && msg.message === 'listen') { if (msg.message && msg.message === 'listen') {
assert(msg.port); assert(msg.port);
const client1 = net.connect({ const client1 = net.connect({
host: 'localhost', host: 'localhost',
port: msg.port port: msg.port
}, function() { }, () => {
const client2 = net.connect({ const client2 = net.connect({
host: 'localhost', host: 'localhost',
port: msg.port port: msg.port
}, function() { }, () => {
client1.on('close', onclose); client1.on('close', onclose);
client2.on('close', onclose); client2.on('close', onclose);
client1.end(); client1.end();
@ -62,10 +62,10 @@ if (cluster.isMaster) {
}); });
}); });
let waiting = 2; let waiting = 2;
function onclose() { const onclose = () => {
if (--waiting === 0) if (--waiting === 0)
cluster.worker.disconnect(); cluster.worker.disconnect();
} };
} else { } else {
process.send('reply', handle); process.send('reply', handle);
} }