1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: make test-tls-external-accessor agnostic

Browse Source 
Remove reliance on V8-specific error messages in
test/parallel/test-tls-external-accessor.js.

Check that the error is a `TypeError`.

The test should now be successful without modification using ChakraCore.

PR-URL: https://github.com/nodejs/node/pull/16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Rich Trott 2017-10-17 16:59:30 -07:00 committed by James M Snell
parent a5a122054f
commit a645d45dd5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-tls-external-accessor.js
View File

@ -11,12 +11,12 @@ const tls = require('tls');
{ {
const pctx = tls.createSecureContext().context; const pctx = tls.createSecureContext().context;
const cctx = Object.create(pctx); const cctx = Object.create(pctx);
assert.throws(() => cctx._external, /incompatible receiver/); assert.throws(() => cctx._external, TypeError);
pctx._external; pctx._external;
} }
{ {
const pctx = tls.createSecurePair().credentials.context; const pctx = tls.createSecurePair().credentials.context;
const cctx = Object.create(pctx); const cctx = Object.create(pctx);
assert.throws(() => cctx._external, /incompatible receiver/); assert.throws(() => cctx._external, TypeError);
pctx._external; pctx._external;
} }