1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "http: reset parser.incoming when server response is finished"

Browse Source 
This reverts commit 779a05d5d1bfe2eeb05386f6415d36f80ca0b3b5.

PR-URL: https://github.com/nodejs/node/pull/29263
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Matteo Collina 2019-08-22 08:39:07 +02:00 committed by Rich Trott
parent d5c3837061
commit a5d9288788
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/_http_server.js
View File

@ -618,8 +618,6 @@ function resOnFinish(req, res, socket, state, server) {
assert(state.incoming.length === 0 || state.incoming[0] === req); assert(state.incoming.length === 0 || state.incoming[0] === req);
state.incoming.shift(); state.incoming.shift();
// Reset the .incoming property so that the request object can be gc'ed.
if (socket.parser) socket.parser.incoming = null;
// If the user never called req.read(), and didn't pipe() or // If the user never called req.read(), and didn't pipe() or
// .resume() or .on('data'), then we call req._dump() so that the // .resume() or .on('data'), then we call req._dump() so that the