From a5d86f8c4ebf201092a7a155691856e13639f0cb Mon Sep 17 00:00:00 2001
From: Tim Seckinger <seckinger.tim@gmail.com>
Date: Sun, 20 May 2018 14:37:28 +0200
Subject: [PATCH] assert: handle undefined filename in getErrMessage

When generating an assertion error message,
`filename` might be undefined,
e.g. if `assert` is called in `eval`.

Handle this case gracefully instead of failing with
`Cannot read property 'endsWith' of undefined`.

Fixes: https://github.com/nodejs/node/issues/20847

PR-URL: https://github.com/nodejs/node/pull/20848
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 lib/assert.js                |  4 ++++
 test/parallel/test-assert.js | 10 ++++++++++
 2 files changed, 14 insertions(+)

diff --git a/lib/assert.js b/lib/assert.js
index 0abe9211278..a528e768747 100644
--- a/lib/assert.js
+++ b/lib/assert.js
@@ -154,6 +154,10 @@ function getBuffer(fd, assertLine) {
 
 function getErrMessage(call) {
   const filename = call.getFileName();
+  if (!filename) {
+    return;
+  }
+
   const line = call.getLineNumber() - 1;
   const column = call.getColumnNumber() - 1;
   const identifier = `${filename}${line}${column}`;
diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
index bb58e2857f4..56489b9e6e8 100644
--- a/test/parallel/test-assert.js
+++ b/test/parallel/test-assert.js
@@ -783,6 +783,16 @@ common.expectsError(
   }
 );
 
+// works in eval
+common.expectsError(
+  () => new Function('assert', 'assert(1 === 2);')(assert),
+  {
+    code: 'ERR_ASSERTION',
+    type: assert.AssertionError,
+    message: 'false == true'
+  }
+);
+
 // Do not try to check Node.js modules.
 {
   const e = new EventEmitter();