1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add dns.onlookupall() to increase coverage

Browse Source 
Added test that callback should be called when error occurs
in dns.lookupall().

PR-URL: https://github.com/nodejs/node/pull/22985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Masashi Hirano 2018-09-20 01:33:52 +09:00 committed by Daniel Bevenius
parent ccbedd55a6
commit a58f37720d
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/internet/test-dns-lookup.js
View File

@ -1,7 +1,9 @@
'use strict';
require('../common');
const dnsPromises = require('dns').promises;
const common = require('../common');
const dns = require('dns');
const dnsPromises = dns.promises;
const { addresses } = require('../common/internet');
const assert = require('assert');
@ -28,3 +30,17 @@ assert.rejects(
message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
}
);
dns.lookup(addresses.INVALID_HOST, {
hints: 0,
family: 0,
all: true
}, common.mustCall((error) => {
assert.strictEqual(error.code, 'ENOTFOUND');
assert.strictEqual(
error.message,
`getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
);
assert.strictEqual(error.syscall, 'getaddrinfo');
assert.strictEqual(error.hostname, addresses.INVALID_HOST);
}));