1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix http2-binding strictEqual order

Browse Source 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: https://github.com/nodejs/node/pull/24616
Refs: https://github.com/nodejsjp/node-1/issues/1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
dominikeinkemmer 2018-11-24 16:56:04 +09:00 committed by Rich Trott
parent 3c4f8a1540
commit a57343c727
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-http2-binding.js
View File

@ -233,16 +233,16 @@ const defaultSettings = {
for (const name of Object.keys(constants)) {
if (name.startsWith('HTTP_STATUS_')) {
assert.strictEqual(expectedStatusCodes[name], constants[name],
assert.strictEqual(constants[name], expectedStatusCodes[name],
`Expected status code match for ${name}`);
} else if (name.startsWith('HTTP2_HEADER_')) {
assert.strictEqual(expectedHeaderNames[name], constants[name],
assert.strictEqual(constants[name], expectedHeaderNames[name],
`Expected header name match for ${name}`);
} else if (name.startsWith('NGHTTP2_')) {
assert.strictEqual(expectedNGConstants[name], constants[name],
assert.strictEqual(constants[name], expectedNGConstants[name],
`Expected ng constant match for ${name}`);
} else if (name.startsWith('DEFAULT_SETTINGS_')) {
assert.strictEqual(defaultSettings[name], constants[name],
assert.strictEqual(constants[name], defaultSettings[name],
`Expected default setting match for ${name}`);
}
}