build: disable custom v8 snapshot by default
This currently breaks `test/pummel/test-hash-seed.js` PR-URL: https://github.com/nodejs/node/pull/27365 Refs: https://github.com/nodejs/node/pull/27321 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This commit is contained in:
parent
d896f03578
commit
a41a4ee61b
12
configure.py
12
configure.py
@ -421,6 +421,11 @@ parser.add_option('--with-ltcg',
|
||||
dest='with_ltcg',
|
||||
help='Use Link Time Code Generation. This feature is only available on Windows.')
|
||||
|
||||
parser.add_option('--with-node-snapshot',
|
||||
action='store_true',
|
||||
dest='with_node_snapshot',
|
||||
help='Turn on V8 snapshot integration. Currently experimental.')
|
||||
|
||||
intl_optgroup.add_option('--download',
|
||||
action='store',
|
||||
dest='download_list',
|
||||
@ -928,6 +933,13 @@ def configure_node(o):
|
||||
o['variables']['want_separate_host_toolset'] = int(
|
||||
cross_compiling and want_snapshots)
|
||||
|
||||
if options.with_node_snapshot:
|
||||
o['variables']['node_use_node_snapshot'] = 'true'
|
||||
else:
|
||||
# Default to false for now.
|
||||
# TODO(joyeecheung): enable it once we fix the hashseed uniqueness
|
||||
o['variables']['node_use_node_snapshot'] = 'false'
|
||||
|
||||
if target_arch == 'arm':
|
||||
configure_arm(o)
|
||||
|
||||
|
3
node.gyp
3
node.gyp
@ -6,6 +6,7 @@
|
||||
'node_use_dtrace%': 'false',
|
||||
'node_use_etw%': 'false',
|
||||
'node_no_browser_globals%': 'false',
|
||||
'node_use_node_snapshot%': 'false',
|
||||
'node_use_v8_platform%': 'true',
|
||||
'node_use_bundled_v8%': 'true',
|
||||
'node_shared%': 'false',
|
||||
@ -431,7 +432,7 @@
|
||||
'src/node_code_cache_stub.cc'
|
||||
],
|
||||
}],
|
||||
['want_separate_host_toolset==0', {
|
||||
['node_use_node_snapshot=="true"', {
|
||||
'dependencies': [
|
||||
'node_mksnapshot',
|
||||
],
|
||||
|
Loading…
x
Reference in New Issue
Block a user