1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util: support AsyncGeneratorFunction in .inspect

Browse Source 
This makes sure async generator functions are properly detected while
using `util.inspect`.

PR-URL: https://github.com/nodejs/node/pull/28056
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Ruben Bridgewater 2019-06-02 16:44:21 +02:00 committed by Rich Trott
parent be721e8db0
commit a23c2308a7
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/internal/util/inspect.js
View File

@ -870,10 +870,11 @@ function getBoxedBase(value, ctx, keys, constructor, tag) {
function getFunctionBase(value, constructor, tag) { function getFunctionBase(value, constructor, tag) {
let type = 'Function'; let type = 'Function';
if (isGeneratorFunction(value)) {
type = `Generator${type}`;
}
if (isAsyncFunction(value)) { if (isAsyncFunction(value)) {
type = 'AsyncFunction'; type = `Async${type}`;
} else if (isGeneratorFunction(value)) {
type = 'GeneratorFunction';
} }
let base = `[${type}`; let base = `[${type}`;
if (constructor === null) { if (constructor === null) {

4
test/parallel/test-util-inspect.js
View File

@ -48,6 +48,10 @@ assert.strictEqual(util.inspect(async () => {}), '[AsyncFunction (anonymous)]');
util.inspect(fn), util.inspect(fn),
'[GeneratorFunction (anonymous)]' '[GeneratorFunction (anonymous)]'
); );
assert.strictEqual(
util.inspect(async function* abc() {}),
'[AsyncGeneratorFunction: abc]'
);
Object.setPrototypeOf(fn, Object.getPrototypeOf(async () => {})); Object.setPrototypeOf(fn, Object.getPrototypeOf(async () => {}));
assert.strictEqual( assert.strictEqual(
util.inspect(fn), util.inspect(fn),