1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: terminate child process on Windows

Browse Source 
test-benchmark-child-process failures reveal that
child-process-exec-stdout benchmark sometimes leaves around a stray
yes.exe process. Add code to terminate the process.

PR-URL: https://github.com/nodejs/node/pull/12658
Ref: https://github.com/nodejs/node/issues/12560
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-04-25 13:48:50 -07:00
parent d8f8096ec6
commit a1a54ca3f1
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
benchmark/child_process/child-process-exec-stdout.js
View File

@ -10,7 +10,8 @@ const bench = common.createBenchmark(main, {
dur: [5] dur: [5]
}); });
const exec = require('child_process').exec; const child_process = require('child_process');
const exec = child_process.exec;
function main(conf) { function main(conf) {
bench.start(); bench.start();
@ -29,7 +30,12 @@ function main(conf) {
}); });
setTimeout(function() { setTimeout(function() {
child.kill();
bench.end(bytes); bench.end(bytes);
if (process.platform === 'win32') {
// Sometimes there's a yes.exe process left hanging around on Windows...
child_process.execSync(`taskkill /f /t /pid ${child.pid}`);
} else {
child.kill();
}
}, dur * 1000); }, dur * 1000);
} }

1
test/sequential/sequential.status
View File

@ -7,7 +7,6 @@ prefix sequential
[true] # This section applies to all platforms [true] # This section applies to all platforms
[$system==win32] [$system==win32]
test-benchmark-child-process : PASS,FLAKY
[$system==linux] [$system==linux]