1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-debug-prompt

Browse Source 
* Use cleaner `process.stdin.write('.exit')` to exit the process rather
  than `proc.kill()`.
* Move test to sequential. It uses the default port 9229. It will fail
  if another inspector test (or test using port 0) is already using that
  port. So it needs to be run sequentially rather than in parallel with
  other tests. (We haven't seen many failures with it yet because there
  aren't a lot of other inspector tests in parallel at this time.)

PR-URL: https://github.com/nodejs/node/pull/15141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-09-01 17:30:10 -07:00 committed by Ruben Bridgewater
parent 5ee2d3ef0e
commit a172b7c51e
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-debug-prompt.js → test/sequential/test-debug-prompt.js
View File

@ -11,5 +11,5 @@ let output = '';
proc.stdout.on('data', (data) => { proc.stdout.on('data', (data) => {
output += data; output += data;
if (output.includes('debug> ')) if (output.includes('debug> '))
proc.kill(); proc.stdin.write('.exit\n');
}); });