1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix fs-watch-recursive flakiness on OS X

Browse Source 
The test is sometimes timing out because of a race condition between
the fs event generated on file creation and the event being registered
in the kqueue. To avoid this problem, create the file after 100 ms,
that is the value used in the `fs_event_watch_dir_recursive` libuv test.

PR-URL: https://github.com/nodejs/node/pull/4629
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Santiago Gimeno 2016-01-11 22:23:17 +01:00
parent 143d38c650
commit a133b775e3
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-fs-watch-recursive.js
View File

@ -34,7 +34,13 @@ watcher.on('change', function(event, filename) {
watcherClosed = true;
});
fs.writeFileSync(filepathOne, 'world');
if (process.platform === 'darwin') {
setTimeout(function() {
fs.writeFileSync(filepathOne, 'world');
}, 100);
} else {
fs.writeFileSync(filepathOne, 'world');
}
process.on('exit', function() {
assert(watcherClosed, 'watcher Object was not closed');