1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix parameters in test-repl.js

Browse Source 
fixed order of parameters in assert.strictEqual() assertion functions,
first argument provided was the expected value and the second value
was the actual value.

this is backwards from the documentation for assertions like
assert.strictEqual() where the first value being tested and the second
value is the expected value

PR-URL: https://github.com/nodejs/node/pull/23609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Israel Ortiz 2018-10-12 11:46:07 -07:00 committed by Ruben Bridgewater
parent 99c16900c8
commit a039c863c4
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-repl.js
View File

@ -784,8 +784,8 @@ function startTCPRepl() {
client.setEncoding('utf8');
client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);
resolveSocket(client);
}));
@ -827,8 +827,8 @@ function startUnixRepl() {
client.setEncoding('utf8');
client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);
resolveSocket(client);
}));