test: remove unused assert module imports

Many test modules load assert but do not use it. This change removes
those instances.

It also removes a handful of other unused variables when they were
nearby.

PR-URL: https://github.com/nodejs/node/pull/4438
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2015-12-26 22:45:46 -08:00 committed by James M Snell
parent 1a004f1187
commit a030c5cf49
42 changed files with 12 additions and 60 deletions

View File

@ -2,7 +2,6 @@
// Flags: --expose-gc
require('../../common');
var assert = require('assert');
var binding = require('./build/Release/binding');
function check(size) {

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
var util = require('util');
console.log([

View File

@ -1,7 +1,6 @@
'use strict';
require('../common');
var assert = require('assert');
var spawn = require('child_process').spawn;

View File

@ -1,5 +1,4 @@
'use strict';
require('../common');
var assert = require('assert');
console.log('hello world');

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
process.nextTick(function() {
process.nextTick(function() {

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
Error.stackTraceLimit = 0;

View File

@ -1,7 +1,6 @@
'use strict';
require('../common');
var assert = require('assert');
var spawn = require('child_process').spawn;

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
// custom error throwing
throw ({ name: 'MyCustomError', message: 'This is a custom message' });

View File

@ -1,4 +1,4 @@
*test*message*throw_custom_error.js:6
*test*message*throw_custom_error.js:5
throw ({ name: 'MyCustomError', message: 'This is a custom message' });
^
MyCustomError: This is a custom message

View File

@ -1,7 +1,6 @@
/* eslint-disable indent */
'use strict';
require('../common');
var assert = require('assert');
console.error('before');

View File

@ -1,5 +1,5 @@
before
*test*message*throw_in_line_with_tabs.js:10
*test*message*throw_in_line_with_tabs.js:9
throw ({ foo: 'bar' });
^
[object Object]

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
// custom error throwing
throw ({ foo: 'bar' });

View File

@ -1,4 +1,4 @@
*test*message*throw_non_error.js:6
*test*message*throw_non_error.js:5
throw ({ foo: 'bar' });
^
[object Object]

View File

@ -1,5 +1,4 @@
'use strict';
require('../common');
var assert = require('assert');
throw null;

View File

@ -1,5 +1,5 @@
*test*message*throw_null.js:5
*test*message*throw_null.js:4
throw null;
^
null

View File

@ -1,5 +1,4 @@
'use strict';
require('../common');
var assert = require('assert');
throw undefined;

View File

@ -1,5 +1,5 @@
*test*message*throw_undefined.js:5
*test*message*throw_undefined.js:4
throw undefined;
^
undefined

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
setTimeout(function() {
undefined_reference_error_maker;

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
var vm = require('vm');
console.error('before');

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
var vm = require('vm');
console.error('beginning');

View File

@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var assert = require('assert');
require('../common');
var vm = require('vm');
console.error('beginning');

View File

@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var assert = require('assert');
require('../common');
var vm = require('vm');
console.error('beginning');

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
var vm = require('vm');
console.error('beginning');

View File

@ -2,7 +2,6 @@
var NUM_WORKERS = 4;
var PACKETS_PER_WORKER = 10;
var assert = require('assert');
var cluster = require('cluster');
var common = require('../common');
var dgram = require('dgram');

View File

@ -1,7 +1,6 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cluster = require('cluster');
const net = require('net');

View File

@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var assert = require('assert');
if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
@ -20,8 +19,6 @@ var options = {
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
};
var canSend = true;
var server = tls.Server(options, function(socket) {
setImmediate(function() {
console.log('sending');
@ -32,17 +29,15 @@ var server = tls.Server(options, function(socket) {
});
});
var client;
function verify() {
console.log('verify');
var verified = crypto.createVerify('RSA-SHA1')
.update('Test')
.verify(certPem, 'asdfasdfas', 'base64');
crypto.createVerify('RSA-SHA1')
.update('Test')
.verify(certPem, 'asdfasdfas', 'base64');
}
server.listen(common.PORT, function() {
client = tls.connect({
tls.connect({
port: common.PORT,
rejectUnauthorized: false
}, function() {

View File

@ -1,8 +1,6 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var fs = require('fs');
var dgram = require('dgram');
var callbacks = 0;
var client;

View File

@ -1,10 +1,7 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var fs = require('fs');
var dgram = require('dgram');
var callbacks = 0;
var client, timer, buf;
if (process.platform === 'darwin') {

View File

@ -2,9 +2,7 @@
// Make sure that the domain stack doesn't get out of hand.
require('../common');
var assert = require('assert');
var domain = require('domain');
var events = require('events');
var a = domain.create();
a.name = 'a';

View File

@ -1,11 +1,10 @@
'use strict';
var assert = require('assert');
var common = require('../common');
var repl = require('repl');
const putIn = new common.ArrayStream();
var testMe = repl.start('', putIn);
repl.start('', putIn);
putIn.write = function(data) {
// Don't use assert for this because the domain might catch it, and

View File

@ -1,5 +1,4 @@
'use strict';
var common = require('../common');
var assert = require('assert');
require(common.fixturesDir + '/require-bin/bin/req.js');

View File

@ -1,6 +1,5 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const stream = require('stream');
const reader = new stream.Readable();

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
var util = require('util');
var stream = require('stream');

View File

@ -16,7 +16,6 @@
*/
require('../common');
var assert = require('assert');
var TIMEOUT_DELAY = 1.1;
var NB_TIMEOUTS_FIRED = 50;

View File

@ -5,7 +5,6 @@
*/
const common = require('../common');
const assert = require('assert');
const net = require('net');
const clients = [];

View File

@ -7,7 +7,6 @@
* considered public interface.
*/
const common = require('../common');
const assert = require('assert');
const timers = require('timers');
const foo = {

View File

@ -3,7 +3,6 @@
* This test is a regression test for joyent/node#8900.
*/
const common = require('../common');
const assert = require('assert');
const TEST_DURATION = common.platformTimeout(100);
const N = 5;

View File

@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var path = require('path');
var fs = require('fs');

View File

@ -3,7 +3,6 @@
// data in random intervals. Clients are also randomly disconnecting until there
// are no more clients left. If no false timeout occurs, this test has passed.
var common = require('../common'),
assert = require('assert'),
http = require('http'),
server = http.createServer(),
connections = 0;

View File

@ -1,6 +1,5 @@
'use strict';
require('../common');
var assert = require('assert');
var complete = 0;

View File

@ -1,7 +1,6 @@
'use strict';
require('../common');
var net = require('net');
var assert = require('assert');
// Connect to something that we need to DNS resolve
var c = net.createConnection(80, 'google.com');

View File

@ -2,10 +2,6 @@
// Make sure that sync writes to stderr get processed before exiting.
require('../common');
var assert = require('assert');
var util = require('util');
var errnoException = util._errnoException;
function parent() {
var spawn = require('child_process').spawn;