1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: change var declarations, add mustCall check

Browse Source 
In this test, I changed the var declarations to be either a let or a
const. For some of the callbacks, I added a mustCall check to ensure
that the functions have run. I also changed assert.equal() to
assert.strictEqual().

PR-URL: https://github.com/nodejs/node/pull/9962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Daniel Sims 2016-12-01 10:54:07 -06:00 committed by Rich Trott
parent b2321c24dc
commit 9fd79c9f5b
1 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
test/parallel/test-cluster-net-send.js
View File

@ -1,29 +1,29 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var fork = require('child_process').fork;
var net = require('net');
const common = require('../common');
const assert = require('assert');
const fork = require('child_process').fork;
const net = require('net');
if (process.argv[2] !== 'child') {
console.error('[%d] master', process.pid);
var worker = fork(__filename, ['child']);
var called = false;
const worker = fork(__filename, ['child']);
let called = false;
worker.once('message', function(msg, handle) {
assert.equal(msg, 'handle');
worker.once('message', common.mustCall(function(msg, handle) {
assert.strictEqual(msg, 'handle');
assert.ok(handle);
worker.send('got');
handle.on('data', function(data) {
called = true;
assert.equal(data.toString(), 'hello');
assert.strictEqual(data.toString(), 'hello');
});
handle.on('end', function() {
worker.kill();
});
});
}));
process.once('exit', function() {
assert.ok(called);
@ -31,20 +31,21 @@ if (process.argv[2] !== 'child') {
} else {
console.error('[%d] worker', process.pid);
var socket;
var cbcalls = 0;
let socket;
let cbcalls = 0;
function socketConnected() {
if (++cbcalls === 2)
process.send('handle', socket);
}
var server = net.createServer(function(c) {
process.once('message', function(msg) {
assert.equal(msg, 'got');
const server = net.createServer(function(c) {
process.once('message', common.mustCall(function(msg) {
assert.strictEqual(msg, 'got');
c.end('hello');
});
}));
socketConnected();
});
server.listen(common.PORT, function() {
socket = net.connect(common.PORT, '127.0.0.1', socketConnected);
});